Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to hide the .highlightMenu #20

Closed
ha-shine opened this issue Mar 5, 2018 · 6 comments · Fixed by #43
Closed

Add an option to hide the .highlightMenu #20

ha-shine opened this issue Mar 5, 2018 · 6 comments · Fixed by #43
Assignees
@thebaer
Labels
enhancement up for grabs
Milestone
v1.4

Comments

@ha-shine
Copy link

ha-shine commented Mar 5, 2018

Add an option to hide the .highlightMenu when you're selecting something.

image

I would make a PR but for some reason the extension doesn't work if I load it locally. You can just do something like document.querySelector('.highlightMenu').style.display = 'none';.

Great work btw 👍
@thebaer thebaer mentioned this issue Mar 5, 2018
Closed
@thebaer thebaer added this to the v1.4 milestone Mar 5, 2018
@thebaer
Copy link
Owner

thebaer commented Mar 5, 2018

Thanks! Will get this added in.

@thebaer thebaer self-assigned this Mar 5, 2018
@Nudin
Copy link
Contributor

Nudin commented Apr 8, 2018

See #25

@thebaer
Copy link
Owner

thebaer commented Apr 9, 2018

Yep, fixed with #25. Will go out in v1.4.

@thebaer thebaer closed this as completed Apr 9, 2018
@pgera
Copy link

pgera commented Oct 19, 2018

Does this still work ? I've enabled it in preferences, but don't see the desired effect. Tested on latest chromium and firefox.

@thebaer thebaer reopened this Oct 22, 2018
@thebaer
Copy link
Owner

thebaer commented Oct 22, 2018

Hmm, looks like it isn't working for me anymore either. Taking a look...

thebaer added a commit that referenced this issue Oct 22, 2018
@thebaer
Fix "disable highlight menu" option not working
524dde5 
This fixes #20 again.
@thebaer thebaer mentioned this issue Oct 22, 2018
Merged
@thevoiceless
Copy link

Looks like this might be broken again, I'm seeing the popup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thebaer thebaer

Labels
enhancement up for grabs
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Fix "disable highlight menu" option not working thebaer/MMRA
5 participants
@Nudin @thebaer @thevoiceless @pgera @ha-shine