Added a feature to serve the app using the terminal command 'php codeholic serve' #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-zanjad
changed the title
aditya-zanjad
changed the title
…lic serve' command...
… which to try running PHP's built-in server on...
|
That is awesome @aditya-zanjad. Thank you for it. |
thecodeholic
requested changes
Sep 25, 2022
.vscode/settings.json
Outdated
| @@ -0,0 +1,2 @@ | |||
| { | |||
There was a problem hiding this comment.
I think we should completely ignore .vscode folder.
codeholic
Outdated
| } | ||
|
|
||
| // If default port is free, run PHP's built-in server on it | ||
| if (exec(`php -S $host:$port -t $pathToMainIndex`)) { |
There was a problem hiding this comment.
When the default port is occupied and this code is executed. Code throws an error and does not try to allocate next port.
There was a problem hiding this comment.
@thecodeholic Thanks for notifying me about these issues. I'll try to fix them ASAP.
…rsion is '8.0.0' or up...
…mework into implement_php_codeholic_serve
|
@thecodeholic Thank you for the feedback. The suggested changes are now implemented. Thank you. |
|
@aditya-zanjad Thank you for this. |
…ncremented in the for loop...
…te exception messages...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an alternate way to serve the app using the terminal command
php codeholic serveFrom the root directory, where
README.mdfile is located, you can now run the following terminal command to serve the app.FIRST NOTE
The file
codeholic.phphas been renamed to justcodeholic.This way we can just run
php codeholic serveinstead ofphp codeholic.php serve.SECOND NOTE
In the fourth commit, added the ability to specify port number & host url for the command
php codeholic serve.Now, we can specify parameters '--port' & '--host'. If the user does not provide any value for
--portargument, then its default value will always be8080.Some examples below:
THIRD NOTE
In the seventh commit, added the option to specify the parameter
--max-portto decide the limit upto which to try to run the PHP's built-in server on before showing a failure message. The value of the parameter--max-portshould always be equal to or greater than the value of the parameter--port.If the user does not provide any value for
--portargument, then its default value will always be8080.Also, there is a hard limit set on the value of
--max-port. This means, the value of--max-portshould never be greater than the addition of value of--portplus100. This is done to make sure that thefor loopin the program will not like run forever.Some valid examples below:
Some invalid examples below: