This repository was archived by the owner on Apr 14, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an interface
GotenbergClientInterface
, implemented by theClient
class.The purpose is to aid testing in other applications so the client class can be easily mocked, as the current
Client
class is final which makes it tricky to simulate in unit tests. Currently when working with tools that do not allow mocking final classes you need to instantiate the client class and mock the http client and internal interactions with the request/response classes, as well as file writes.Test plan (required)
I've not added any tests as this is a non-functional change - we could test the interface is implemented though if you think it's worth it?
Checklist
make lint
)?make tests
)?