Skip to content

Migrating away from better-reflection #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

moufmouf
Copy link
Member

@moufmouf moufmouf commented Sep 5, 2018

There is no real need to have a dependency on better-reflection as most of what want is parsing a docblock. This is done by the phpDocumentor/docblock library and we can rely on that alone.

  • this solves dependency issues because a lot of libs are needing nikic/php-parser that is also required by better-reflection

@coveralls
Copy link

coveralls commented Sep 5, 2018

Coverage Status

Coverage increased (+0.1%) to 73.258% when pulling cbc8511 on moufmouf:removing_better_reflection into 8d7923f on thecodingmachine:master.

@moufmouf moufmouf merged commit ebe6457 into thecodingmachine:master Sep 5, 2018
@moufmouf moufmouf deleted the removing_better_reflection branch September 5, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants