Make ClassNameMapper injectable in SchemaFactory
#144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @flow-control , Looks good to me! Quite impressed with your PR ;) Would you mind adding just a call to the Also, just out of curiosity, in what scenario did you need to inject a new |
|
Hey @moufmouf, we @OXID-eSales are building a GraphQL API on top of our e-commerce system, which will not be part of the core distribution but installable as a plugin. This means, that projects I will fix the code coverage and btw.: thanks for this very awesome library 👍 /Flo |
|
Thanks a lot! 👍 |
realFlowControl
added a commit
to realFlowControl/graphqlite
that referenced
this pull request
Oct 9, 2019
realFlowControl
added a commit
to realFlowControl/graphqlite
that referenced
this pull request
Oct 11, 2019
moufmouf
added a commit
that referenced
this pull request
Oct 14, 2019
…able-in-3.0 Backport classNameMapper injectability from #144 to graphqlite v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the
ClassNameMapperinstance injectable via setter in theSchemaFactory. If not injected, everything behaves as before this PR.