Fix issue with kept deprecation reason #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaapio I've merged a PR that addresses the phpcs issues, if you could please just merge |
When a type contains multiple fields and one of them is deprecated the following fields will be marked as deprecated. By resetting the value in each run we make sure the value is not kept.
jaapio
force-pushed
the
fix/deprecation-reason
branch
from
f798490 to
1a1d224
Compare
|
Thanks, I rebased my branch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
============================================
- Coverage 95.72% 94.87% -0.86%
- Complexity 1773 1824 +51
============================================
Files 154 174 +20
Lines 4586 4971 +385
============================================
+ Hits 4390 4716 +326
- Misses 196 255 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oojacoboo
approved these changes
Mar 24, 2025
|
@jaapio @stijnie2210 merged. Thanks! |
|
thanks for your review and merge. Can we expect a release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type contains multiple fields and one of them is deprecated the following fields will be marked as deprecated. By resetting the value in each run we make sure the value is not kept.
With @stijnie2210