Skip to content

Fixing an issue if there is no alias in subquery #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

Fixing an issue if there is no alias in subquery #69

merged 2 commits into from
Jul 22, 2020

Conversation

moufmouf
Copy link
Member

This PR fixes an issue with query of the type:

SELECT COUNT(*) FROM (SELECT DISTINCT states.country_id, states.code FROM states)

(with no alias in the subquery).

Starts with a failing test

@coveralls
Copy link

coveralls commented Jul 22, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 70.681% when pulling 306f4f4 on moufmouf:fix_another_alias into 1294fd8 on thecodingmachine:1.4.

@moufmouf moufmouf merged commit 3de7b7c into thecodingmachine:1.4 Jul 22, 2020
@moufmouf moufmouf deleted the fix_another_alias branch July 22, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moufmouf @coveralls