Fix problem with http_headers, duplicated or bad setted in Symfony Response #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If you don't remove old headers, it's duplicated in HTTP Headers | ||
| foreach ($headers as $key => $head) { | ||
| header_remove($key); | ||
| } |
There was a problem hiding this comment.
I believe you could simply call header_remove(); to remove all headers (and therefore skip the foreach loop):
http://php.net/manual/fr/function.header-remove.php
Apart from this very small comment, I'm completely ok with this PR 👍
There was a problem hiding this comment.
Thx for you comment.
I don't use header_remove without parameters because php.net indicate :
Caution
This function will remove all headers set by PHP, including cookies, session and the X-Powered-By headers.
moufmouf
added a commit
that referenced
this pull request
May 27, 2015
Fix problem with http_headers, duplicated or bad setted in Symfony Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Setting "header('Cache-Control: public, max-age=3600');" in my controller bad setted in Symfony Response (You set 0 in key and "Cache-Control: public, max-age=3600" in value).
This bug create duplication of HTTP Headers.
Solution
Use "greatResponseHeaders" (copy of apache_response_headers but available for all servers) and remove old http_headers because Symfony add all headers after pass to constructor.