Incorrect createFromPhpError() method?

[snapshotpl]

Every generated exception method e.g. https://github.com/thecodingmachine/safe/blob/master/generated/Exceptions/FilesystemException.php contains createFromPhpError() method where exception is created from json_last_error(). Is it correct behaviour?

Source:

safe/generator/src/FileCreator.php

Line 157 in 50f1e60

return new self(\json_last_error_msg(), \json_last_error());

[Kharhamel]

No it's not. Looks like I was dumb enough to copy paste the wrong code. I will fix this soon

[Kharhamel]

Also we should have some kind of tests for theses generated exceptions

[Kharhamel]

#170

[Kharhamel]

this is in the beta4. however i think we feel like there is something to improve with the way we generate our exceptions.

[snapshotpl]

@Kharhamel you talk about code duplication?