Fix createFromFormat for PHP 8 #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snapshotpl
approved these changes
Jun 15, 2021
KevinVanSonsbeek
approved these changes
Jul 16, 2021
|
Thanks @Jean85 |
can you explain this, please? which library? |
|
@bendavies I was referring to the warning atop the readme, which was removed here: 56ab933#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L12-L26 https://github.com/thecodingmachine/safe8 was created for it, but I don't know what will happen... maybe they chose to not deprecate this lib? |
|
Minds were changed indeed and we're now working on a new release for the current library to support PHP8 :) @Jean85 @bendavies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a transparent fix for #250;
I understand that this library should be abandoned, butthis fix will allow us to use it under PHP 8.0 without this bug, buying us time to build a new major(or Safe8).[EDIT] As explained below, this library will NOT be abandoned.