PHP8 compatibility #279
Closed
PHP8 compatibility #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrekelmans
commented
Jul 19, 2021
| * @throws DatetimeException | ||
| * | ||
| */ | ||
| function date(string $format, int $timestamp = null): string |
There was a problem hiding this comment.
I'm not sure why this has been removed.. it seems locally I get some different results from the generator than github actions, even though I confirmed I'm running the exact same PHP version (8.0.8)
|
Probably if you merge #264 first, this PR will be a lot smaller :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started by merging in all changes from
thecodingmachine/safe8, regenerating the files and worked my way towards fixing the build.