Unresolvable conflict

[grachevko]

Hello. Thank you for great library.

I have installed https://github.com/infection/infection tools, which require safe lib. My project use php8, and i want to install safe8 for it. But i can't install both, because you fork lib without changing namespace and php crash on trying to redeclare functions.

If we will have major release where v1 require php < 8.0 and v2 required php >= 8.0 then we can required v1 || v2 in infection and be happy without conflicts.

So why just not made major release instead of forking library?

[djcrock]

I ran into the same issue. As a workaround, I was able to add a replace map to my composer.json like so:

{
...
  "require": {
    "php": "^8.0",
    "thecodingmachine/safe8": "^0.1"
  },
  "require-dev": {
    "infection/infection": "^0.21"
  },
  "replace": {
    "thecodingmachine/safe": "*"
  },
...
}

This prevents safe from being installed by the infection requirement (causing it to use the safe8 version I installed instead, since the class/function names are the same).

Including this replace map directly in the safe8 library's composer.json might be a good compromise to allow interoperability if forking the library is the only way to go. However, I do agree that it would be preferable to release a new major version of thecodingmachine/safe without forking.

[kminek]

i also dont understand why a fork was created - this looks like terrible idea. so if PHP9 comes out in future you will create another fork? just bump major version and document the change so its clear for end-users about minimal PHP version requirement. problem solved.