Skip to content

implemented a cache and a cache clearer in tdbm bundle #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2020
Merged

implemented a cache and a cache clearer in tdbm bundle #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
/Tests export-ignore
/phpstan.neon export-ignore
/phpcs.xml.dist export-ignore
/phpcs.xml export-ignore
/.gitignore export-ignore
/.travis.yml export-ignore
11 changes: 11 additions & 0 deletions Resources/config/container/tdbm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,19 @@
<argument key="$codeGeneratorListeners" type="collection">
<argument type="service" id="TheCodingMachine\TDBM\Bundle\Utils\SymfonyCodeGeneratorListener"/>
</argument>
<argument key="$cache" type="service" id="tdbm.cache"></argument>
</service>

<service id="tdbm.cache" class="Doctrine\Common\Cache\FilesystemCache">
<argument>%kernel.project_dir%/var/cache/tdbm</argument>
</service>


<service id="tdbm.cacheclearer" class="TheCodingMachine\TDBM\Bundle\Utils\DoctrineCacheClearer">
<argument type="service" id="tdbm.cache" />
<tag name="kernel.cache_clearer"/>
</service>

<service id="TheCodingMachine\TDBM\ConfigurationInterface" alias="TheCodingMachine\TDBM\Configuration">
</service>

Expand Down
2 changes: 1 addition & 1 deletion Tests/Fixtures/config/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ services:

# makes classes in src/ available to be used as services
# this creates a service per class whose id is the fully-qualified class name
TheCodingMachine\Graphqlite\Bundle\Tests\Fixtures\:
TheCodingMachine\TDBM\Bundle\Tests\Fixtures\:
resource: '../*'
exclude: '../{Entities}'

Expand Down
1 change: 0 additions & 1 deletion Tests/FunctionalTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpFoundation\Request;
use TheCodingMachine\GraphQLite\Schema;
use TheCodingMachine\TDBM\TDBMService;

class FunctionalTest extends TestCase
Expand Down
2 changes: 0 additions & 2 deletions Tests/TdbmTestingKernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\Routing\RouteCollectionBuilder;
use TheCodingMachine\Graphqlite\Bundle\GraphqliteBundle;
use TheCodingMachine\TDBM\Bundle\TdbmBundle;
use TheCodingMachine\TDBM\Bundle\TdbmGraphqlBundle;

class TdbmTestingKernel extends Kernel
{
Expand Down
28 changes: 28 additions & 0 deletions Utils/DoctrineCacheClearer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<?php


namespace TheCodingMachine\TDBM\Bundle\Utils;

use Doctrine\Common\Cache\FlushableCache;
use Symfony\Component\HttpKernel\CacheClearer\CacheClearerInterface;

class DoctrineCacheClearer implements CacheClearerInterface
{
/**
* @var FlushableCache
*/
private $cache;

public function __construct(FlushableCache $cache)
{
$this->cache = $cache;
}

/**
* Clears any caches necessary.
*/
public function clear($cacheDir)
{
$this->cache->flushAll();
}
}
5 changes: 3 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"php" : ">=7.1",
"thecodingmachine/tdbm" : "~5.1.0",
"doctrine/doctrine-bundle": "^1.9 || ^2",
"doctrine/orm": "^1 || ^2"
"doctrine/orm": "^1 || ^2",
"symfony/http-kernel": "^4.1.9 || ^5"
},
"require-dev": {
"roave/security-advisories": "dev-master",
Expand All @@ -34,7 +35,7 @@
"phpstan/phpstan-shim": "^0.11.4"
},
"scripts": {
"phpstan": "phpstan analyse TdbmBundle.php DependencyInjection/ Resources/ -c phpstan.neon --level=7 --no-progress"
"phpstan": "phpstan analyse TdbmBundle.php DependencyInjection/ Resources/ Utils/ -c phpstan.neon --level=7 --no-progress"
},
"autoload" : {
"psr-4" : {
Expand Down