Skip to content

Dist - Exclude test/CI files from composer archive #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dsavina
Copy link
Contributor

@dsavina dsavina commented Dec 17, 2020

Unless test classes are actually used in other projects tests, which seems like a very bad habit to me, I think we don't need to distribute them. Same goes for code checks. Only doubt is the exclusion of all hidden files (.*)

@codecov-io
Copy link

codecov-io commented Dec 17, 2020

Codecov Report

Merging #241 (22eae8f) into master (a49d62d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #241   +/-   ##
=========================================
  Coverage     97.54%   97.54%           
  Complexity     1482     1482           
=========================================
  Files            62       62           
  Lines          4159     4159           
=========================================
  Hits           4057     4057           
  Misses          102      102           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49d62d...22eae8f. Read the comment docs.

@homersimpsons
Copy link
Collaborator

Thank you @dsavina

Maybe you should prefix the excluded paths / files with / in order to avoid any unintended exclusion.

Signed-off-by: Dorian Savina <d.savina@thecodingmachine.com>
@dsavina dsavina force-pushed the dist/archive-excluded-files branch from 22eae8f to e7a3c4b Compare January 4, 2021 10:02
@dsavina
Copy link
Contributor Author

dsavina commented Jan 4, 2021

Done!

@moufmouf moufmouf merged commit ed4baa8 into thecodingmachine:master Jan 6, 2021
@dsavina dsavina deleted the dist/archive-excluded-files branch September 12, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants