"QueryDeletedNode" clears node settings regardless of calling AcceptDeletedItem/RejectDeletedItem

[MultiPain]

If you have an empty loop:

NodeEditor::NodeId nodeID;
while (NodeEditor::QueryDeletedNode(&nodeID))
{
}

then when you try to delete a node, it will be moved to (0; 0)

similarly if you have something like this:

NodeEditor::NodeId nodeID;
while (NodeEditor::QueryDeletedNode(&nodeID))
{
   auto node = getNode(nodeID);
   if (node->isLocked())
   {
      NodeEditor::RejectDeletedItem();
   }
   else
   {
      if (NodeEditor::AcceptDeletedItem()) { /*...*/ }
   }
}

The problem is here:

imgui-node-editor/imgui_node_editor.cpp

Lines 5094 to 5096 in 459d2d7

	Editor->RemoveSettings(item);
	item->m_DeleteOnNewFrame = true;

in ed::DeleteItemsAction::RejectItem:

imgui-node-editor/imgui_node_editor.cpp

Line 5072 in 459d2d7

RemoveItem(deleteDependencies);

and

imgui-node-editor/imgui_node_editor.cpp

Line 5030 in 459d2d7

RejectItem();

[thedmd]

I pushed a fix to this. Can you check if it does work for you?

[MultiPain]

@thedmd no, still goes to (0; 0)
I guess
Editor->RemoveSettings(item);
should be moved aswell

[thedmd]

@MultiPain I amended last fix, given it wasn't live long.
Deleting should now behave correctly.
Can you double check?

[MultiPain]

@thedmd works good

[thedmd]

Enjoy : )