Update facter to 4.0.51 #6348
Merged
Update facter to 4.0.51 #6348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do3meli
suggested changes
Mar 1, 2021
| @@ -88,6 +88,9 @@ cp -a .%{_bindir}/* \ | |||
| %doc %{gem_docdir} | |||
|
|
|||
| %changelog | |||
| * Wed Feb 24 2021 Lukas Zapletal <lzap+rpm@redhat.com> 4.0.51-1 | |||
| - Update to 5.0.51 | |||
There was a problem hiding this comment.
i guess here is a typo. that should be 4.0.51 and not 5.0.51 i assume.
There was a problem hiding this comment.
For what it's worth, ./bump_rpm.sh packages/foreman/rubygem-facter should generally do the right thing for you already. With gems it even knows how to pull the latest gem version.
There was a problem hiding this comment.
Damn thanks, why I keep forgetting this script. In the past we had nothing like this and I am still used to the old workflow. Rebased.
There was a problem hiding this comment.
It's been there for 3 years now, time to adjust your habits :)
lzap
force-pushed
the
rpm/develop-facter-4.0.51.gem
branch
from
6fbf915
to
a4a7667
Compare
do3meli
approved these changes
Mar 2, 2021
ehelms
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix https://projects.theforeman.org/issues/31943
For plugin updates, please indicate which repos this should be built into:
According to testing of the problem, I might actually file 2.4 PR. But first things first - nightly and I need to test this.