Update rubygem-foreman_bootdisk to 19.0.6 #8311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stejskalleos
force-pushed
the
ls/rpm/boot19.0.6
branch
from
e26901b
to
9709687
Compare
|
@theforeman/packaging Hi can we merge the PR? |
|
Not if it's not building? ;) |
evgeni
requested changes
Sep 1, 2022
| Requires: %{?scl_prefix_ruby}ruby(release) | ||
| Requires: %{?scl_prefix_ruby}ruby >= 2.5 | ||
| Requires: %{?scl_prefix_ruby}ruby(rubygems) | ||
| Requires: ruby >= 2.5 |
There was a problem hiding this comment.
You're dropping SCL macros, but 3.3 us still building for EL7 with SCL
| BuildRequires: npm(@babel/core) >= 7.7.0 | ||
| BuildRequires: npm(@babel/core) < 8.0.0 | ||
| BuildRequires: npm(@theforeman/builder) >= 8.15.0 | ||
| BuildRequires: npm(@theforeman/builder) < 9.0.0 |
There was a problem hiding this comment.
I bet this one can't be satisfied (we're using v10) and should not be here
theforeman-bot
added
Waiting on contributor
RPM
Stable branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Foreman 3.3