Fixes #35543 - Explicitly vendor sinatra in Foreman #8513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7848a0a)
ehelms
approved these changes
Sep 20, 2022
theforeman-bot
added
DEB
Stable branch
|
Looks like it is not passing -- so you may need to split, either way it's an ACK from me however you want to handle it |
|
[test deb] |
|
I opened #8514 to do just the Foreman changes. |
(cherry picked from commit cdbd9c0)
ekohl
force-pushed
the
deb/3.4-35543-explicitly-vendor-sinatra
branch
from
915883e
to
c58ebc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks the changes from develop to avoid 2 packages shipping the same file. I don't know if I can submit this in one PR, given one depends on the other.