-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pipeline playbooks based on refactoring of roles #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this supersede #329?
playbooks/upgrade.yml
Outdated
foreman_installer_upgrade: True | ||
foreman_repositories_use_koji: True | ||
katello_repositories_use_koji: True | ||
foreman_installer_module_prs: "katello/candlepin/44,katello/katello/79,katello/capsule/96,katello/certs/65" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These PRs are already merged, any reason why you're pinning here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope - that was an oversight from testing the qpid on localhost. I'll cleanup.
Its possible something is wrong locally, but I'm seeing this when running
Full error:
|
playbooks/pipeline_katello_32.yml
Outdated
become: yes | ||
tasks: | ||
- yum: | ||
name: libselinux-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe include the selinux role instead?
On the 3.2 pipeline:
|
Looks like http://projects.theforeman.org/issues/16479 did not get properly included in the 3.2 commit stream @johnpmitsch |
bc4511f
to
0526ad7
Compare
Any progress on this? |
I think this is still good to go as is with the latest 3.2. Probably needs to be re-tested by someone. |
Given @johnpmitsch is working on 3.2.1 release, he will likely be re-testing these changes. |
Getting an error
|
may be easier to read: https://paste.fedoraproject.org/507515/19174301/ |
Weird, your VMs aren't resolving hostname properly. |
I've seen the resolving error when vagrant up fails somewhere, but the box is booted up and used. @ehelms this needs a rebase. |
e951c7b
to
c38a1c9
Compare
I've noticed I introduced a regression in bats which #354 should fix. Then after adding The 3.2 pipeline fails to install katello-agent for me because yum can't find it. |
@ekohl the pipeline as is fails or using the new set of tests? |
@ehelms current PR. With the nightly I get:
|
@ekohl sorted now, dashes for the scenario name |
Current nightly failure:
Should be fixed by theforeman/puppet-certs#114 |
@ekohl would you like to hold off on this being merged until that fix? |
@ehelms not sure, currently the pipeline is broken anyway so this at least gets us closer to it. |
06d79d9
to
738a995
Compare
I added 3.3 playbooks as well. @ekohl since the CI pipeline doesn't use these, I'd like to get them in as soon as we can to share them and iterate on them for release work. |
@ehelms what does the CI pipeline use? And I'm fine with merging. Like I said, currently it's all broken that Ansible won't even run for me so 👍 |
@ekohl right now the CI uses a bash script modeled after foreman_systest in part due to:
|
Current tests:
|
I believe this can be fixed by installing the client repository in |
I updated this to remove the repos from foreman_proxy_content as katello_repositories should be used and added the client to the koji_repos. |
3.3 now fails on a dependency of katello-agent:
Since this is an actual pipeline failure rather than the configuration for the tests I'd suggest to merge this now. |
Looks like Katello/katello-packaging@397d674 needs to be backported to 3.3. |
Per Katello/katello-packaging#337 (comment) it's fixed. |
@ekohl have you re-tested since that backport? or given that are you ready to merge this? |
@ehelms 3.3 passes at least, running on 3.2 now but 👍 on merging. |
3.2 needs 2 runs because the proxy registration fails on the first due to a connection refused, but haven't looked at the logs why. |
@ekohl from what we have seen, that is some error that occurs sometimes when using Puppet 3 only. We have had an issue for abit but not been able to diagnose it -- http://projects.theforeman.org/issues/16653 |
Per #374 it should also include the proxy tests on the correct hosts. |
6e100d1
to
1b68d14
Compare
1b68d14
to
b10e01f
Compare
@ekohl I added proxy tests for each pipeline playbook. |
@ekohl I am going to merge this, then re-factor the existing pipeline playbooks into my Pipeline role PR. Sound good? |
@ehelms very good |
No description provided.