Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline playbooks based on refactoring of roles #331

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Nov 14, 2016

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this supersede #329?

foreman_installer_upgrade: True
foreman_repositories_use_koji: True
katello_repositories_use_koji: True
foreman_installer_module_prs: "katello/candlepin/44,katello/katello/79,katello/capsule/96,katello/certs/65"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These PRs are already merged, any reason why you're pinning here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - that was an oversight from testing the qpid on localhost. I'll cleanup.

@johnpmitsch
Copy link
Contributor

Its possible something is wrong locally, but I'm seeing this when running ansible-playbook playbooks/pipeline_katello_32.yml:

The box failed to unpackage properly. Please verify that the box\nfile you're trying to add is not corrupted and try again.

Full error:


TASK [Bring up box for Katello] ************************************************
Monday 14 November 2016  13:36:23 -0500 (0:00:00.825)       0:00:00.867 ******* 
fatal: [localhost]: FAILED! => {"changed": true, "cmd": ["vagrant", "up", "pipeline-katello-3.2-centos7"], "delta": "0:00:27.149921", "end": "2016-11-14 13:36:51.125138", "failed": true, "rc": 1, "start": "2016-11-14 13:36:23.975217", "stderr": "The box failed to unpackage properly. Please verify that the box\nfile you're trying to add is not corrupted and try again. The\noutput from attempting to unpackage (if any):\n\nx Vagrantfile\nx box.img: Write failed\nx metadata.json: Write failed\nbsdtar: Error exit delayed from previous errors.", "stdout": "Bringing machine 'pipeline-katello-3.2-centos7' up with 'libvirt' provider...\n==> pipeline-katello-3.2-centos7: Box 'centos/7' could not be found. Attempting to find and install...\n    pipeline-katello-3.2-centos7: Box Provider: libvirt\n    pipeline-katello-3.2-centos7: Box Version: >= 0\n==> pipeline-katello-3.2-centos7: Loading metadata for box 'centos/7'\n    pipeline-katello-3.2-centos7: URL: https://atlas.hashicorp.com/centos/7\n==> pipeline-katello-3.2-centos7: Adding box 'centos/7' (v1609.01) for provider: libvirt\n    pipeline-katello-3.2-centos7: Downloading: https://atlas.hashicorp.com/centos/boxes/7/versions/1609.01/providers/libvirt.box\n\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 0% (Rate: 0/s, Estimated time remaining: --:--:--)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 1% (Rate: 14.3M/s, Estimated time remaining: 0:00:30)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 12% (Rate: 51.0M/s, Estimated time remaining: 0:00:09)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 24% (Rate: 50.1M/s, Estimated time remaining: 0:00:07)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 34% (Rate: 47.7M/s, Estimated time remaining: 0:00:07)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 38% (Rate: 40.6M/s, Estimated time remaining: 0:00:07)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 41% (Rate: 35.4M/s, Estimated time remaining: 0:00:07)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 45% (Rate: 28.5M/s, Estimated time remaining: 0:00:08)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 49% (Rate: 22.2M/s, Estimated time remaining: 0:00:07)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 54% (Rate: 17.5M/s, Estimated time remaining: 0:00:07)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 58% (Rate: 17.8M/s, Estimated time remaining: 0:00:07)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 63% (Rate: 19.3M/s, Estimated time remaining: 0:00:06)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 69% (Rate: 20.8M/s, Estimated time remaining: 0:00:05)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 75% (Rate: 22.2M/s, Estimated time remaining: 0:00:04)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 81% (Rate: 23.6M/s, Estimated time remaining: 0:00:03)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 87% (Rate: 25.0M/s, Estimated time remaining: 0:00:02)\r\u001b[K    pipeline-katello-3.2-centos7: Progress: 94% (Rate: 26.4M/s, Estimated time remaining: 0:00:01)\r\u001b[K", "stdout_lines": ["Bringing machine 'pipeline-katello-3.2-centos7' up with 'libvirt' provider...", "==> pipeline-katello-3.2-centos7: Box 'centos/7' could not be found. Attempting to find and install...", "    pipeline-katello-3.2-centos7: Box Provider: libvirt", "    pipeline-katello-3.2-centos7: Box Version: >= 0", "==> pipeline-katello-3.2-centos7: Loading metadata for box 'centos/7'", "    pipeline-katello-3.2-centos7: URL: https://atlas.hashicorp.com/centos/7", "==> pipeline-katello-3.2-centos7: Adding box 'centos/7' (v1609.01) for provider: libvirt", "    pipeline-katello-3.2-centos7: Downloading: https://atlas.hashicorp.com/centos/boxes/7/versions/1609.01/providers/libvirt.box", "", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 0% (Rate: 0/s, Estimated time remaining: --:--:--)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 1% (Rate: 14.3M/s, Estimated time remaining: 0:00:30)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 12% (Rate: 51.0M/s, Estimated time remaining: 0:00:09)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 24% (Rate: 50.1M/s, Estimated time remaining: 0:00:07)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 34% (Rate: 47.7M/s, Estimated time remaining: 0:00:07)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 38% (Rate: 40.6M/s, Estimated time remaining: 0:00:07)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 41% (Rate: 35.4M/s, Estimated time remaining: 0:00:07)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 45% (Rate: 28.5M/s, Estimated time remaining: 0:00:08)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 49% (Rate: 22.2M/s, Estimated time remaining: 0:00:07)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 54% (Rate: 17.5M/s, Estimated time remaining: 0:00:07)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 58% (Rate: 17.8M/s, Estimated time remaining: 0:00:07)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 63% (Rate: 19.3M/s, Estimated time remaining: 0:00:06)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 69% (Rate: 20.8M/s, Estimated time remaining: 0:00:05)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 75% (Rate: 22.2M/s, Estimated time remaining: 0:00:04)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 81% (Rate: 23.6M/s, Estimated time remaining: 0:00:03)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 87% (Rate: 25.0M/s, Estimated time remaining: 0:00:02)", "\u001b[K    pipeline-katello-3.2-centos7: Progress: 94% (Rate: 26.4M/s, Estimated time remaining: 0:00:01)", "\u001b[K"], "warnings": []}

become: yes
tasks:
- yum:
name: libselinux-python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe include the selinux role instead?

@ekohl
Copy link
Member

ekohl commented Nov 14, 2016

On the 3.2 pipeline:

TASK [capsule : Generate Certs] ************************************************
Monday 14 November 2016  20:19:21 +0100 (0:00:00.210)       0:03:04.351 ******* 
fatal: [pipeline-capsule-3.2-centos7 -> None]: FAILED! => {"changed": true, "cmd": ["capsule-certs-generate", "--capsule-fqdn", "pipeline-capsule-3-2-centos7.example.com", "--certs-tar", "/root/pipeline-capsule-3-2-centos7.example.com.tar.gz"], "delta": "0:00:05.419794", "end": "2016-11-14 19:19:27.403444", "failed": true, "rc": 1, "start": "2016-11-14 19:19:21.983650", "stderr": "stty: standard input: Inappropriate ioctl for device\nThis system has less than 8 GB of total memory. Please have at least 8 GB of total ram free before running the installer.", "stdout": "", "stdout_lines": [], "warnings": []}

cmd: 
capsule-certs-generate
--capsule-fqdn
pipeline-capsule-3-2-centos7.example.com
--certs-tar
/root/pipeline-capsule-3-2-centos7.example.com.tar.gz

start: 2016-11-14 19:19:21.983650

end: 2016-11-14 19:19:27.403444

delta: 0:00:05.419794

stderr: stty: standard input: Inappropriate ioctl for device
This system has less than 8 GB of total memory. Please have at least 8 GB of total ram free before running the installer.

@ehelms
Copy link
Member Author

ehelms commented Nov 15, 2016

Looks like http://projects.theforeman.org/issues/16479 did not get properly included in the 3.2 commit stream @johnpmitsch

@ehelms ehelms force-pushed the fix-pipelines branch 2 times, most recently from bc4511f to 0526ad7 Compare November 16, 2016 15:49
@ekohl
Copy link
Member

ekohl commented Nov 30, 2016

Any progress on this?

@ehelms
Copy link
Member Author

ehelms commented Dec 13, 2016

I think this is still good to go as is with the latest 3.2. Probably needs to be re-tested by someone.

@ehelms
Copy link
Member Author

ehelms commented Dec 13, 2016

Given @johnpmitsch is working on 3.2.1 release, he will likely be re-testing these changes.

@johnpmitsch
Copy link
Contributor

Getting an error

fatal: [pipeline-capsule-3.2-centos7]: FAILED! => {"changed": true, "cmd": "foreman-installer -v --scenario \"capsule\"  --disable-system-checks --foreman-proxy-trusted-hosts \"pipeline-katello-3-2-centos7.example.com\" --foreman-proxy-trusted-hosts \"localhost.localdomain\" --foreman-proxy-foreman-base-url \"https://pipeline-katello-3-2-centos7.example.com\" --foreman-proxy-register-in-foreman true --foreman-proxy-oauth-consumer-key \"LFuHLJW46o5eKSK7U3TH5Z3sqV9QCPpr\" --foreman-proxy-oauth-consumer-secret \"2nDY5cdN7pRY2z3xw3GJipzofaFjWMw9\" --capsule-certs-tar \"/root/localhost.localdomain.tar.gz\" --capsule-parent-fqdn \"pipeline-katello-3-2-centos7.example.com\" --capsule-pulp-oauth-secret \"kV5nGz9Zx3JmpofZiG6HE8YrzZn4Ua33\"", "delta": "0:00:04.818878", "end": "2016-12-16 19:32:24.757116", "failed": true, "rc": 20, "start": "2016-12-16 19:32:19.938238", "stderr": "Output of 'hostname -f' does not seems to be valid FQDN\n\nMake sure above command gives fully qualified domain name. At least one\ndot must be present and underscores are not allowed. If 'hostname -f' still returns unexpected result, check /etc/hosts\nand put the hostname entry in the correct order, for example:\n\n  1.2.3.4 hostname.example.com hostname\n\nFully qualified hostname must be the first entry on the line", "stdout": "Your system does not meet configuration criteria\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Executing hooks in group pre_migrations\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] All hooks in group pre_migrations finished\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Executing hooks in group boot\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] All hooks in group boot finished\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Executing hooks in group init\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] All hooks in group init finished\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Loading default values from puppet modules...\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] ... finished\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Executing hooks in group pre_values\n[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] All hooks in group pre_values finished", "stdout_lines": ["Your system does not meet configuration criteria", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Executing hooks in group pre_migrations", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] All hooks in group pre_migrations finished", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Executing hooks in group boot", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] All hooks in group boot finished", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Executing hooks in group init", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] All hooks in group init finished", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Loading default values from puppet modules...", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] ... finished", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] Executing hooks in group pre_values", "[\u001b[32m INFO\u001b[0m \u001b[34m2016-12-16 19:32:24\u001b[0m \u001b[36mverbose\u001b[0m] All hooks in group pre_values finished"], "warnings": []}

@johnpmitsch
Copy link
Contributor

may be easier to read: https://paste.fedoraproject.org/507515/19174301/

@ehelms
Copy link
Member Author

ehelms commented Dec 16, 2016

Weird, your VMs aren't resolving hostname properly.

@johnpmitsch johnpmitsch mentioned this pull request Dec 16, 2016
@ekohl
Copy link
Member

ekohl commented Jan 4, 2017

I've seen the resolving error when vagrant up fails somewhere, but the box is booted up and used.

@ehelms this needs a rebase.

@ehelms ehelms force-pushed the fix-pipelines branch 2 times, most recently from e951c7b to c38a1c9 Compare January 5, 2017 15:04
@ekohl
Copy link
Member

ekohl commented Jan 5, 2017

I've noticed I introduced a regression in bats which #354 should fix. Then after adding --foreman-proxy-dns=true --foreman-proxy-dns-managed=true --foreman-proxy-dns-reverse=121.168.192.in-addr.arpa --foreman-proxy-dns-reverse=8.b.d.0.1.0.0.2.ip6.arpa to the proxy it should also pass the DNS tests.

The 3.2 pipeline fails to install katello-agent for me because yum can't find it.

@ehelms
Copy link
Member Author

ehelms commented Jan 5, 2017

@ekohl the pipeline as is fails or using the new set of tests?

@ekohl
Copy link
Member

ekohl commented Jan 5, 2017

@ehelms current PR.

With the nightly I get:

stdout: ERROR: Scenario (/etc/foreman-installer/scenarios.d/foreman_proxy_content.yaml) was not found, can not continue

@ehelms
Copy link
Member Author

ehelms commented Jan 5, 2017

@ekohl sorted now, dashes for the scenario name

@ekohl
Copy link
Member

ekohl commented Jan 6, 2017

Current nightly failure:

Parameter regenerate invalid: "$certs::params::regenerate" is not a valid boolean
Parameter regenerate-ca invalid: "$certs::params::regenerate_ca" is not a valid boolean

Should be fixed by theforeman/puppet-certs#114

@ehelms
Copy link
Member Author

ehelms commented Jan 7, 2017

@ekohl would you like to hold off on this being merged until that fix?

@ekohl
Copy link
Member

ekohl commented Jan 7, 2017

@ehelms not sure, currently the pipeline is broken anyway so this at least gets us closer to it.

@ehelms ehelms force-pushed the fix-pipelines branch 2 times, most recently from 06d79d9 to 738a995 Compare January 9, 2017 18:18
@ehelms
Copy link
Member Author

ehelms commented Jan 9, 2017

I added 3.3 playbooks as well. @ekohl since the CI pipeline doesn't use these, I'd like to get them in as soon as we can to share them and iterate on them for release work.

@ekohl
Copy link
Member

ekohl commented Jan 9, 2017

@ehelms what does the CI pipeline use? And I'm fine with merging. Like I said, currently it's all broken that Ansible won't even run for me so 👍

@ehelms
Copy link
Member Author

ehelms commented Jan 9, 2017

@ekohl right now the CI uses a bash script modeled after foreman_systest in part due to:

  1. need to get Ansible on the slaves (fairly easy)
  2. We've avoided foreman-proxy testing due to perceived limits on Rackspace usage quota

@ekohl
Copy link
Member

ekohl commented Jan 9, 2017

Current tests:

not ok 20 install katello-agent
# (from function `tIsRedHatCompatible' in file os_helper.bash, line 4,
#  from function `tPackageInstall' in file os_helper.bash, line 89,
#  in test file fb-content-katello.bats, line 140)
#   `tPackageInstall katello-agent && tPackageExists katello-agent' failed
# Loaded plugins: fastestmirror, product-id, search-disabled-repos, subscription-
#               : manager
# Loading mirror speeds from cached hostfile
#  * base: nl.mirror.babylon.network
#  * epel: nl.mirror.babylon.network
#  * extras: nl.mirror.babylon.network
#  * updates: nl.mirror.babylon.network
# No package katello-agent available.
# Error: Nothing to do
not ok 21 start katello-agent
# (in test file fb-content-katello.bats, line 144)
#   `service goferd status || service goferd start' failed with status 5
# Redirecting to /bin/systemctl status  goferd.service
# Unit goferd.service could not be found.
# Redirecting to /bin/systemctl start  goferd.service
# Failed to start goferd.service: Unit not found.

@ekohl
Copy link
Member

ekohl commented Jan 10, 2017

3.3 fails bats tests on katello-agent:

I believe this can be fixed by installing the client repository in playbooks/roles/foreman_proxy_content/tasks/koji_repos.yml (which looks an awful lot like playbooks/roles/katello_repositories/tasks/koji_repos.yml):

@ehelms
Copy link
Member Author

ehelms commented Jan 10, 2017

I updated this to remove the repos from foreman_proxy_content as katello_repositories should be used and added the client to the koji_repos.

@ekohl
Copy link
Member

ekohl commented Jan 10, 2017

3.3 now fails on a dependency of katello-agent:

not ok 20 install katello-agent
# (from function `tIsRedHatCompatible' in file os_helper.bash, line 4,
#  from function `tPackageInstall' in file os_helper.bash, line 89,
#  in test file fb-content-katello.bats, line 140)
#   `tPackageInstall katello-agent && tPackageExists katello-agent' failed
# Loaded plugins: fastestmirror, product-id, search-disabled-repos, subscription-
#               : manager
# Loading mirror speeds from cached hostfile
#  * base: nl.mirror.babylon.network
#  * epel: nl.mirror.babylon.network
#  * extras: nl.mirror.babylon.network
#  * updates: nl.mirror.babylon.network
# Resolving Dependencies
# --> Running transaction check
# ---> Package katello-agent.noarch 0:2.8.0-1.el7 will be installed
# --> Processing Dependency: python2-tracer >= 1.6.12 for package: katello-agent-2.8.0-1.el7.noarch
# --> Processing Dependency: python-pulp-agent-lib >= 2.6 for package: katello-agent-2.8.0-1.el7.noarch
# --> Processing Dependency: python-gofer-proton >= 2.5 for package: katello-agent-2.8.0-1.el7.noarch
# --> Processing Dependency: pulp-rpm-handlers >= 2.6 for package: katello-agent-2.8.0-1.el7.noarch
# --> Processing Dependency: gofer >= 2.5 for package: katello-agent-2.8.0-1.el7.noarch
# --> Processing Dependency: katello-agent-fact-plugin for package: katello-agent-2.8.0-1.el7.noarch
# --> Running transaction check
# ---> Package gofer.noarch 0:2.7.6-1.el7 will be installed
# ---> Package katello-agent.noarch 0:2.8.0-1.el7 will be installed
# --> Processing Dependency: python2-tracer >= 1.6.12 for package: katello-agent-2.8.0-1.el7.noarch
# ---> Package katello-agent-fact-plugin.noarch 0:2.8.0-1.el7 will be installed
# ---> Package pulp-rpm-handlers.noarch 0:2.10.3-1.el7 will be installed
# ---> Package python-gofer-proton.noarch 0:2.7.6-1.el7 will be installed
# --> Processing Dependency: python-qpid-proton >= 0.9-5 for package: python-gofer-proton-2.7.6-1.el7.noarch
# ---> Package python-pulp-agent-lib.noarch 0:2.10.3-1.el7 will be installed
# --> Running transaction check
# ---> Package katello-agent.noarch 0:2.8.0-1.el7 will be installed
# --> Processing Dependency: python2-tracer >= 1.6.12 for package: katello-agent-2.8.0-1.el7.noarch
# ---> Package python-qpid-proton.x86_64 0:0.14.0-1.el7 will be installed
# --> Finished Dependency Resolution
# Error: Package: katello-agent-2.8.0-1.el7.noarch (katello-client-koji)
#            Requires: python2-tracer >= 1.6.12
#            Available: python2-tracer-0.6.12-4.el7.noarch (epel)
#                python2-tracer = 0.6.12-4.el7
#  You could try using --skip-broken to work around the problem
#  You could try running: rpm -Va --nofiles --nodigest

Since this is an actual pipeline failure rather than the configuration for the tests I'd suggest to merge this now.

@ekohl
Copy link
Member

ekohl commented Jan 10, 2017

Looks like Katello/katello-packaging@397d674 needs to be backported to 3.3.

@ekohl
Copy link
Member

ekohl commented Jan 10, 2017

Looks like Katello/katello-packaging@397d674 needs to be backported to 3.3.

Per Katello/katello-packaging#337 (comment) it's fixed.

@ehelms
Copy link
Member Author

ehelms commented Jan 23, 2017

@ekohl have you re-tested since that backport? or given that are you ready to merge this?

@ekohl
Copy link
Member

ekohl commented Jan 23, 2017

@ehelms 3.3 passes at least, running on 3.2 now but 👍 on merging.

@ekohl
Copy link
Member

ekohl commented Jan 24, 2017

3.2 needs 2 runs because the proxy registration fails on the first due to a connection refused, but haven't looked at the logs why.

@ehelms
Copy link
Member Author

ehelms commented Jan 24, 2017

@ekohl from what we have seen, that is some error that occurs sometimes when using Puppet 3 only. We have had an issue for abit but not been able to diagnose it -- http://projects.theforeman.org/issues/16653

@ekohl
Copy link
Member

ekohl commented Jan 31, 2017

Per #374 it should also include the proxy tests on the correct hosts.

@ehelms
Copy link
Member Author

ehelms commented Feb 10, 2017

@ekohl I added proxy tests for each pipeline playbook.

@ehelms
Copy link
Member Author

ehelms commented Feb 13, 2017

@ekohl I am going to merge this, then re-factor the existing pipeline playbooks into my Pipeline role PR. Sound good?

@ekohl
Copy link
Member

ekohl commented Feb 13, 2017

@ehelms very good

@ehelms ehelms merged commit b6da7cd into theforeman:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants