Introduce Forklift role for spinning up pipelines #390
Conversation
|
@stbenjam if you wouldn't mind looking at this in comparison to the other design |
ehelms
force-pushed
the
pipelines-2.0
branch
from
641f31c
to
33d17a6
Compare
|
I would be curious about other people's opinions, it's more cumbersome to type but it's ansible only which is nice. The idea of a vagrant plugin also might be a good one - it doesn't seem too bad https://www.vagrantup.com/docs/plugins/commands.html |
|
I'm not opposed to the change, however I'm not a huge fan of having to provide 'magic' env variables unless we can provide some sort of help when they aren't provided. Maybe adding an ansible task to print out information if forklift_state == '' |
|
@ehelms who gave you access to the Obama time machine??? ACK from me |
|
ahh nevermind, obama time machine still safely secured, yes exactly like that |
ehelms
force-pushed
the
pipelines-2.0
branch
from
33d17a6
to
5e82c78
Compare
|
@jlsherrill Ok, give it a check now |
|
ACK from me, will defer to @stbenjam or others for any other comments |
| --- | ||
| - name: 'Check variables defined' | ||
| fail: | ||
| msg: 'Please define forklift_name which deteremines the file boxes are deployed to' |
| - name: 'Ensure .tmp_boxes directory' | ||
| file: | ||
| state: directory | ||
| path: "{{ lookup('pipe','dirname `pwd`') }}/.tmp_boxes" |
There was a problem hiding this comment.
Is this safe to assume? Given this logic is duplicated I also think it'd nicer to capture it into a variable.
ehelms
force-pushed
the
pipelines-2.0
branch
2 times, most recently
from
24cdba9
to
5f7c7f8
Compare
|
Updated with comments, also this is rebased on master and each of the existing playbooks were re-factored and put under a directory. |
|
I wonder if we should generalize it. Like a |
|
@ekohl I think that is a good idea, want to throw it in an issue for now since it would require users to update their environments? |
|
Created #392 to track it. |
ehelms
force-pushed
the
pipelines-2.0
branch
from
5f7c7f8
to
21036a8
Compare
This is take 2 on providing a bit more ease of use for defining and spinning up what we call pipelines and would replace the design from #381. The idea here is to introduce a small role that deploys temporary box files based on the boxes defined for the role to be used by the other plays. The boxes can be spin up or destroyed through the single playbook.
The PR includes a pipeline file as an example. The idea would be to apply this to whats defined in #331
Example:
Create boxes and provision:
Destroy pipeline: