Skip to content

Support the using declaration from explicit resource management #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

Support the using declaration from explicit resource management #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e501f8
Support the `using` declaration from explicit resource management
cowboyd Dec 20, 2023
c6382ef
Add changeset
cowboyd Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-pans-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-prefer-let": patch
---

Support the `using` declaration from explicit resource management
2 changes: 1 addition & 1 deletion packages/eslint-plugin-prefer-let/lib/rules/prefer-let.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ module.exports = {
message: 'prefer `let` over `var` to declare value bindings',
node
});
} else if (node.kind !== 'let' && !isTopLevelScope(node)) {
} else if (node.kind === 'const' && !isTopLevelScope(node)) {
let constToken = sourceCode.getFirstToken(node);

context.report({
Expand Down
7 changes: 5 additions & 2 deletions packages/eslint-plugin-prefer-let/tests/lib/rules/prefer-let.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,10 @@ ruleTester.run("prefer-let", rule, {
node: true
},
code: "const PI = 3.14;"
}
},
// Not sure how to test these.
// { code: "await using disposables = new AsyncDisposableStack()" },
// { code: "using disposables = new DisposableStack()" },
],

invalid: [
Expand Down Expand Up @@ -99,6 +102,6 @@ ruleTester.run("prefer-let", rule, {
message: "`const` declaration outside top-level scope",
type: "VariableDeclaration"
}]
}
},
]
});