Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set USE_GKE_GCLOUD_AUTH_PLUGIN env to use gcloud auth plugin in deploy process #191

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

jbolda
Copy link
Contributor

@jbolda jbolda commented Jan 6, 2023

Motivation

As part of #190, we swapped to use the auth plugin. It seems that we may have missed the env var to enable the gcloud CLI to actually use it as noted in this comment.

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2023

⚠️ No Changeset found

Latest commit: 96e43a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frontsidejack
Copy link
Member

📣 NOTIFICATION
You are receiving this message because we did not publish any packages.

Generated by @thefrontside/actions Frontside

@taras taras self-requested a review January 6, 2023 18:41
Copy link
Member

@taras taras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbolda jbolda merged commit fed118d into main Jan 6, 2023
@jbolda jbolda deleted the gke-gcloud-auth-plugin-env branch January 6, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants