Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag range finder should ignore comments, as in brace range finder #22

Closed
simonrob opened this issue Oct 6, 2013 · 1 comment
Closed

Tag range finder should ignore comments, as in brace range finder #22

simonrob opened this issue Oct 6, 2013 · 1 comment

Comments

@simonrob
Copy link

simonrob commented Oct 6, 2013

At the moment, html code folding doesn't ignore tags in comments (e.g., <!-- <body> -->), which messes up code folding, causing tag mismatches. For a simple example, see the Brackets getting started example that comes with the app.

This isn't the case with files that use the brace range finder, so a simple solution would be to just ignore comments, like is done in that approach.

I'll submit a pull request if I get chance to look at the code in more detail.
thehogfather added a commit that referenced this issue Oct 7, 2013
@thehogfather
Fix for issue #22
195e7b9 
updated tagRangeFinder.js to ignore tags that appear in the context of comments in html/xml type documents.
@thehogfather
Copy link
Owner

Good shout. Should be fixed now. Probably needs testing and then I'll push it to the registry in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonrob @thehogfather