Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no differences by adding mock point #8

Merged
merged 3 commits into from
Jun 21, 2021
Merged

fix no differences by adding mock point #8

merged 3 commits into from
Jun 21, 2021

Conversation

egarcialara
Copy link

No description provided.

@egarcialara egarcialara mentioned this pull request Jun 16, 2021
Merged
MaximMoinat
MaximMoinat reviewed Jun 17, 2021
View reviewed changes
Copy link

@MaximMoinat MaximMoinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works. However, why would we even make an empty plot? Just printing the message like 'No differences found' and exiting is a more elegant solution.

@egarcialara egarcialara merged commit 5196ec9 into fix-dqd-compare Jun 21, 2021
@egarcialara egarcialara deleted the fix-dqd-compare-NoDifferences branch June 21, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximMoinat MaximMoinat MaximMoinat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egarcialara @MaximMoinat