Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License compliance #32

Merged
merged 10 commits into from
Oct 24, 2023
Merged

License compliance #32

merged 10 commits into from
Oct 24, 2023

Conversation

janblom
Copy link

@janblom janblom commented Oct 23, 2023

This is actually a bit more than just license compliance:

  • move to java 17 for tests and verification (so java 17 is required to build, and enforced for that reason)
  • enforce the built artifact to still be java 8 (1.8) compatible
  • add fat jar building (for future releases, current way of distributing is still supported)
  • small stuff

@janblom
Update main.yml
56cdb66 
Project now requires Java 17 to build. Should still produce java 8 (1.8) compatible artifacts though.
blootsvoets
blootsvoets approved these changes Oct 24, 2023
View reviewed changes
Copy link

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janblom janblom merged commit d6d56b4 into master Oct 24, 2023
1 check passed
@janblom janblom deleted the license-compliance branch October 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blootsvoets blootsvoets blootsvoets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janblom @blootsvoets @jan-at-the-hyve