Uplift and bump version to 0.8.1-theia005 #2
Conversation
paul-marechal
force-pushed
the
mp/uplift-0.8.1
branch
from
39f9798
to
95b226e
Compare
|
Previously uplifted against master's tip, but I updated the PR to only uplift against 0.8.1 release. node-pty test suite is still green on Ubuntu 16.04 |
|
This project comes with an |
ok, let's try this update: I'll try on my personal fork first. |
|
The azure pipelines thing seems to work now on my fork: https://github.com/marcdumais-work/node-pty/pull/1 The build fails because of a linting issue in file |
paul-marechal
force-pushed
the
mp/uplift-0.8.1
branch
3 times, most recently
from
dadfab6
to
565f2c2
Compare
|
The tests are now passing, but I cannot rebase and merge because of conflict, it may have to do with how I uplifted (pull), so I will try something else. |
this is the minimum viable "it works" build - it's dirty, it relies on knowing features are coming in the RS5 SDK, and is super fragile.
Clean out dead code, actually define some magic, leave some todo's in areas that need help
Add comment about console.log which will add extra space to output text
Optional dev deps aren't supported by npm
Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
We used to tag versions using the format `x.x.x-theiaYYY`, but we may use proper npm tags insteads see: https://docs.npmjs.com/misc/semver#prerelease-tags Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
paul-marechal
force-pushed
the
mp/uplift-0.8.1
branch
from
565f2c2
to
c7fe087
Compare
Integration tests might be required against Theia, but the node-pty test suite is green.