Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix versioning #225

Merged
merged 19 commits into from
Jul 2, 2020
Merged

Fix versioning #225

merged 19 commits into from
Jul 2, 2020

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Jul 1, 2020

Implements #94

@michalk8 michalk8 mentioned this pull request Jul 1, 2020
@michalk8
Copy link
Collaborator Author

michalk8 commented Jul 1, 2020

@Marius1311 - I think we will be able to put this on PyPI soon. However I'd like these to be merge before an official release:

Also we should start documenting the releases in our docs.

@michalk8
Copy link
Collaborator Author

michalk8 commented Jul 1, 2020

@Marius1311 Can you try downloading from PyPI test?
pip install -i https://test.pypi.org/simple/ cellrank==1.2.1a0

@Marius1311
Copy link
Collaborator

Thanks Mike! #222 is done. #219 mainly aims at our transition matrix to be the same as scanpy's in case we only use a ConnectivityKernel. I will open a PR for this with an associated test that makes this more obvious. I should be able to do this later today or tomorrow.

@Marius1311
Copy link
Collaborator

Re #141, fine by me to require scanpy>=1.5. Feel free to make the required changes and to close #144

@Marius1311
Copy link
Collaborator

Re #192, maybe Phil can help? manual would be fine with me for now as well.

@Marius1311
Copy link
Collaborator

Okay, running pip install -i https://test.pypi.org/simple/ cellrank==1.2.1a0 gives me

ERROR: Could not find a version that satisfies the requirement matplotlib>=3.0.3 (from cellrank==1.2.1a0) (from versions: 2.2.3)
ERROR: No matching distribution found for matplotlib>=3.0.3 (from cellrank==1.2.1a0)

@Marius1311
Copy link
Collaborator

I'm running python 3.6 in a new conda environment if that helps.

@Marius1311
Copy link
Collaborator

#219 is not super relevant at the moment, we can safely do this after pypi release.

@michalk8
Copy link
Collaborator Author

michalk8 commented Jul 2, 2020

Ok, let's do it as follows: I will fix #141 and post in on PyPI as pre-release (i.e. v1.0.0-alpha or similar). Once the manuscript is done (and other issues are fixed), we'll bump the version.

@Marius1311
Copy link
Collaborator

sounds good to me.

@michalk8 michalk8 merged commit 1ef59a5 into master Jul 2, 2020
@michalk8 michalk8 deleted the fix_versioning branch July 2, 2020 20:22
michalk8 added a commit that referenced this pull request Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants