Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which loss is moscot printing? #12

Closed
Marius1311 opened this issue Sep 13, 2021 · 2 comments · Fixed by #19
Closed

Which loss is moscot printing? #12

Marius1311 opened this issue Sep 13, 2021 · 2 comments · Fixed by #19
Assignees

Comments

@Marius1311
Copy link
Collaborator

moscot and POT have different printout, see Fig. 1 and 2, resp. Which loss does moscot print?

Fig. 1 (moscot)

Screenshot 2021-09-13 at 11 21 47

Fig. 2 (POT)

Screenshot 2021-09-13 at 11 22 13

@michalk8
Copy link
Collaborator

We print the same as in novosparc np.linalg.norm(T - T_prev), POT actually prints the value of the loss function,
see here, the abs. loss is abs(loss - loss_prev) and the rel. loss is abs(loss - loss_prev) / abs(loss).

@Marius1311
Copy link
Collaborator Author

Doing it like POT makes more sense to me, it's easier to spot convergence that way I think .

MUCDK pushed a commit that referenced this issue Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants