Feature/check marginals convergence #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoepiran
reviewed
Oct 28, 2021
moscot/_mixins.py
Outdated
| @@ -59,7 +59,7 @@ def matrix(self) -> jnp.array: | |||
| """Transport matrix.""" | |||
| if self._transport is None: | |||
| raise RuntimeError("Not fitted.") | |||
There was a problem hiding this comment.
maybe "Valid transportation map was not found." / "No valid transportation map found." ?
zoepiran
reviewed
Oct 28, 2021
MUCDK
pushed a commit
that referenced
this pull request
Jan 17, 2022
* Add warning if not converged * Add check for marginals * Fix tests * Update error msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if marginals are satisfied and whether we've reached max. number of iterations in
FGW.@zoepiran let me know if the warning/error messages are informative enough (feel free to improve them)
closes #40 #43