Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kBET import issue #350

Merged
merged 13 commits into from
Nov 22, 2022
Merged

Fix kBET import issue #350

merged 13 commits into from
Nov 22, 2022

Conversation

mumichae
Copy link
Collaborator

@mumichae mumichae commented Nov 21, 2022

Closes #349
Closes #270

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #350 (18d231a) into main (e028e04) will increase coverage by 3.08%.
The diff coverage is 42.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   56.45%   59.53%   +3.08%     
==========================================
  Files          39       39              
  Lines        2122     2123       +1     
==========================================
+ Hits         1198     1264      +66     
+ Misses        924      859      -65     
Flag Coverage Δ
unittest 59.53% <42.85%> (+3.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scib/metrics/kbet.py 71.96% <0.00%> (+51.40%) ⬆️
scib/exceptions.py 40.00% <33.33%> (-10.00%) ⬇️
tests/metrics/rpy2/test_kbet.py 100.00% <100.00%> (ø)
scib/metrics/utils.py 33.82% <0.00%> (+17.64%) ⬆️

@lazappi
Copy link
Member

lazappi commented Nov 22, 2022

It's probably better to use {remotes} to install stuff rather than {devtools}. It has much fewer dependencies so it will make things faster.

Copy link
Collaborator

@LuckyMD LuckyMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side. But maybe you want to take on board @lazappi's comment above.

@mumichae
Copy link
Collaborator Author

It's probably better to use {remotes} to install stuff rather than {devtools}. It has much fewer dependencies so it will make things faster.

Thanks, that'll make things much easier!

@mumichae mumichae marked this pull request as ready for review November 22, 2022 18:33
@mumichae mumichae merged commit ddf1c9e into main Nov 22, 2022
@mumichae mumichae deleted the fix_kbet_import branch November 22, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kBET module not found error is supplanted by an np.nan return Proper kBet test
3 participants