-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kBET import issue #350
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
+ Coverage 56.45% 59.53% +3.08%
==========================================
Files 39 39
Lines 2122 2123 +1
==========================================
+ Hits 1198 1264 +66
+ Misses 924 859 -65
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It's probably better to use {remotes} to install stuff rather than {devtools}. It has much fewer dependencies so it will make things faster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from my side. But maybe you want to take on board @lazappi's comment above.
Thanks, that'll make things much easier! |
Closes #349
Closes #270