Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set names when reading LISI CSV files #380

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Set names when reading LISI CSV files #380

merged 2 commits into from
Jul 24, 2023

Conversation

lazappi
Copy link
Member

@lazappi lazappi commented Mar 29, 2023

Set names when reading the CSV files produced by C++ code in the LISI functions so that pandas knows how many columns to expect.

Fixes #374 (hopefully, but could do with some more testing)

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #380 (2d6a3b9) into main (cce7aaa) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   53.26%   53.29%   +0.02%     
==========================================
  Files          22       22              
  Lines        1851     1852       +1     
==========================================
+ Hits          986      987       +1     
  Misses        865      865              
Flag Coverage Δ
unittests 53.29% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scib/metrics/lisi.py 42.28% <100.00%> (+0.15%) ⬆️

@lazappi lazappi requested a review from mumichae March 29, 2023 15:22
@mumichae mumichae merged commit d9f9e50 into main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error runing LISI when reading index file
2 participants