Fix leaking tensors #213
Merged
Fix leaking tensors #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ks/node #213 +/- ##
===========================================
+ Coverage 87.70% 87.89% +0.19%
===========================================
Files 8 8
Lines 301 314 +13
Branches 46 46
===========================================
+ Hits 264 276 +12
- Misses 37 38 +1
Continue to review full report at Codecov.
|
Closed
thekevinscott
added a commit
that referenced
this pull request
Feb 27, 2022
* Expose Node package (#161) * Set up Node build and Node integration tests * Cut canary release (#179) * Remove postinstall set:tfjs command (#182) * Move set:tfjs to prepare step * Publish next canary version * Add Node Example to examples folder (#181) * Update example script (#183) * Support a GPU build (#184) * Integration Tests for Loading Model in Browser (#186) * Add tests for loading models via Node (#187) * Add test to ensure model definitions are loaded in browser (#188) * Add test to ensure model definitions are loaded in Node (#189) * Bump versions * Add image unit tests (#191) * Separate image.ts into separate files and add it to the generation script (#192) * Add integration test for upscaling a rank 4 tensor (#193) * Leverage tf.browser.fromPixels on input (#194) * Manipulated scaffolding code to ensure build processes are referencing the correct builds (#195) * Move all but browser tests to leverage puppeteer (#196) * Remove generated files from repo (#197) * Do not include generated files in repo * Add script to scaffold browser generated files after installing * Scaffold on install (#198) * Do not include generated files in repo * Add script to scaffold browser generated files after installing * Enforce minimum Node version (#199) * Specify exact version of Node for unit tests, and add 14- and 16- specific Node integration tests (#201) * Disable CI cache (#204) * Update changelog (#203) * Add umd field in package json (#202) * Migrate linter (#200) Migrate linter from tslint to eslint * Bump lowest node support to 16 (#205) * Bump lowest node support to 16 * Add support for image loading in Node (#206) * Remove scaffolding step (#207) * Add an integration test checking patch sizes (#211) * Sets up in-browser unit testing for *.browser tests (#210) * Add an example for loading a model locally in Node (#212) * Fix leaking tensors (#213) * Update package.json scripts to enable publishing (#214) * Update documentation to include Node (#215) * Update scripts for updating version across repo (#218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61
This PR fixes leaking tensors and adds tests that check that memory consumption nets to 0.