Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: remove version from CTCP response #4834

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Feb 1, 2024

Closes #1344
Closes #4785 (?)

Instead of making this configurable as in #4780, just remove the version number altogether. See discussion: #4785 (comment)

cc @MaxLeiter @brunnre8

@brunnre8
Copy link
Member

Thanks for tolerating the "we don't really know or agree what we want" dance...
Appreciate your contribution.

@brunnre8 brunnre8 merged commit c09f751 into thelounge:master Feb 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTCP VERSION response handling Allow hiding version number from CTCP VERSION response.
2 participants