Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs caused by `this` and optimize the loading of cheerio #1042

Merged
merged 2 commits into from Aug 1, 2019

Conversation

@stevenjoezhang
Copy link
Member

commented Aug 1, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
Fix
@stevenjoezhang stevenjoezhang added this to the v7.4.0 milestone Aug 1, 2019
@stevenjoezhang stevenjoezhang added this to In progress in Feats. / Imprs. / Fixes via automation Aug 1, 2019
@auto-assign auto-assign bot requested review from ivan-nginx, maple3142 and sli1989 Aug 1, 2019
Fix
Feats. / Imprs. / Fixes automation moved this from In progress to Reviewer approved Aug 1, 2019
@1v9
1v9 approved these changes Aug 1, 2019
@1v9 1v9 merged commit 84983c5 into master Aug 1, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Feats. / Imprs. / Fixes automation moved this from Reviewer approved to Done Aug 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix branch Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.