Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sub-menu feature. #156

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Added sub-menu feature. #156

merged 2 commits into from
Mar 14, 2018

Conversation

ivan-nginx
Copy link
Member

@ivan-nginx ivan-nginx commented Mar 3, 2018 •
edited
Loading

  1. Added dynamic sub-menu option in main menu option within hierarchy structure.
  2. Added select class in menu items for all possible sub-menu's (utils.js).
  3. Removed float: right menu style in Mist scheme for better sub-menu(s) alignment.

How to use?

menu:
  News: / || info-circle
  Docs:
    default: /docs/ || book
    Getting Started: /getting-started/ || flag
    Theme Settings: /theme-settings/ || star
    Third Party Services:
      default: /third-party-services/ || plug
      Algolia Search: /algolia-search/ || adn
    Tag Plugins: /tag-plugins/ || rocket
    Advanced Settings: /advanced-settings/ || rocket
    FAQ's: /faqs/ || life-ring
    Platforms: /platforms/ || retweet

How it looks?

Feature adapted for all schemes and, of course, needed to improve. For first release it looks like this:

Muse

image

Mist

image

Pisces

image

Gemini

image

Tests needed

Please, confirm this feature to insure there is no bugs.

@ivan-nginx
Added sub-menu feature.
f85bc00 
1. Added dynamic sub-menu option in main `menu` option within hierarchy structure.
2. Added select class in menu items for all possible sub-menu's (utils.js).
3. Removed `float: right` menu style in Mist scheme for better sub-menu(s) alignment.
@ivan-nginx ivan-nginx added this to the v6.0.6 milestone Mar 3, 2018
@sli1989
Copy link
Collaborator

sli1989 commented Mar 6, 2018

Works fine in NexT.Muse v6.0.5.
_20180306144431

@ivan-nginx ivan-nginx merged commit baac829 into master Mar 14, 2018
@ivan-nginx ivan-nginx deleted the sub-menu-feature branch March 14, 2018 05:16
This was referenced Mar 15, 2018
Closed
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@ivan-nginx
Merge pull request theme-next#156 from theme-next/sub-menu-feature
07fa01c 
Added sub-menu feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsanie tsanie Awaiting requested review from tsanie

@wafer-li wafer-li Awaiting requested review from wafer-li

@maple3142 maple3142 Awaiting requested review from maple3142

@Acris Acris Awaiting requested review from Acris

@geekrainy geekrainy Awaiting requested review from geekrainy

@flashlab flashlab Awaiting requested review from flashlab

@LEAFERx LEAFERx Awaiting requested review from LEAFERx

@Blealtan Blealtan Awaiting requested review from Blealtan

Assignees
No one assigned
Labels
⭐ Feature
Projects
None yet
Milestone
v6.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-nginx @sli1989