Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option onmoble for sidebar wasn't worked #808

Merged
merged 9 commits into from
Apr 4, 2019
Merged

Option onmoble for sidebar wasn't worked #808

merged 9 commits into from
Apr 4, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #807

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx
Copy link
Member

ivan-nginx commented Apr 4, 2019 •
edited
Loading

Also, I wan't to create new issue for similar component and report here:

image

Color changed on hover b2t or sidebar toggle buttons. It's not must be (not was before). And this detected in #684.

@stevenjoezhang
Copy link
Contributor Author

I think it's all fine. The old behaviour is even worse and confusing users.

@ivan-nginx
Copy link
Member

What's fine? Bug fine or what?

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Apr 4, 2019 •
edited
Loading

It's feature.

What I mean is: it's not bug.

@stevenjoezhang
Copy link
Contributor Author

It's better than before. So it's fine. That's simple.

@ivan-nginx
Copy link
Member

ivan-nginx commented Apr 4, 2019 •
edited by stevenjoezhang
Loading

It's feature.

Then create a feature with this. No need to do excess additionals.

@ivan-nginx
Copy link
Member

It's better than before. So it's fine. That's simple.

Better or not – no your question. For now we have:

  1. Bug reported in No sidebar in mobile when it open #807 and «fix» with additional bug (removed opacity & right align)
  2. Added no-needed feature with hovering highlight. Highlight must be on posts, when TOC is exists.

@stevenjoezhang
Copy link
Contributor Author

So you want opacity: 0.8 on mobile?

@ivan-nginx
Copy link
Member

ivan-nginx commented Apr 4, 2019 •
edited by unfurl-links bot
Loading

https://github.com/theme-next/hexo-theme-next/pull/808/files#r272229828

GitHub
PR Checklist Please check if your PR fulfills the following requirements:

The commit message follows our guidelines.
Tests for the changes was maked (for bug fixes / features).

Muse | Mist ha...

@ivan-nginx
Copy link
Member

I want no excess changes for anything. See? We get 2 bugs after your refactorings.

@stevenjoezhang
Copy link
Contributor Author

Ok, ok, it's my fault. What about now?

@ivan-nginx
Copy link
Member

Now right align needed. From fixbutton, how was before.

@stevenjoezhang
Copy link
Contributor Author

About right margin, we only have one macro: $b2t-position-right, equal to 30px
Need another one like $b2t-position-right-mobile?

@ivan-nginx
Copy link
Member

Need another one like $b2t-position-right-mobile?

I think yes.

@ivan-nginx
Copy link
Member

About margins... I see with other options and other schemes positions different in other resolutions. It's not seems like bugs, but can be improved in the future.

@stevenjoezhang
Copy link
Contributor Author

We can use em as unit of margin, like in #800

And, the font-size of back2top button could be larger in high-resolution screens.

@ivan-nginx
Copy link
Member

We can use em as unit of margin, like in #800

And, the font-size of back2top button could be larger in high-resolution screens.

Yep. But i think not now, are u agree? At least after fonts refactoring.
And your comment can be posted as issue with low priority, for example.

@ivan-nginx ivan-nginx mentioned this pull request Apr 4, 2019
Closed
33 tasks
@stevenjoezhang stevenjoezhang added this to the v7.2.0 milestone Apr 4, 2019
@stevenjoezhang
Copy link
Contributor Author

Agree. Needs to be done in the future.

@stevenjoezhang stevenjoezhang merged commit 8ed5d6e into theme-next:master Apr 4, 2019
@stevenjoezhang stevenjoezhang deleted the sidebar branch April 4, 2019 16:44
@ivan-nginx ivan-nginx changed the title Fix wrong sidebar style on mobile Option onmoble for sidebar wasn't worked Apr 4, 2019
invkrh added a commit to invkrh/hexo-theme-next that referenced this pull request Apr 13, 2019
@invkrh
Merge remote-tracking branch 'upstream/master'
77c47c9 
* upstream/master: (65 commits)
  fix theme-next#815 (theme-next#828)
  Update IPC url (theme-next#827)
  List items appeared correctly in mobile with `mobile_layout_economy` option (theme-next#817)
  New translations en.yml (French) (theme-next#819)
  Improve French translation (theme-next#818)
  Fix wrong sidebar style on mobile (theme-next#808)
  Delete inactive reviewer
  New translations en.yml (Spanish) (theme-next#806)
  CSS bug in Codeblock if string longer than viewport (theme-next#803)
  Commented Project
  Temporairly turn off Project checking
  Disable Projects compairing
  Fix `vv` for Release Drafter
  Spanish translation (theme-next#801)
  Optimize images (theme-next#802)
  Release v7.1.0
  Change Algolia link in config
  Reduce reviewers for remove scrolling in PR's (theme-next#797)
  Disable add Assigners in Auto Assign bot (theme-next#795)
  Bug Fix: PDF won't display in particular situation (theme-next#794)
  ...
@stevenjoezhang stevenjoezhang mentioned this pull request Apr 16, 2019
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Fix wrong sidebar style on mobile (theme-next#808)
8737140 
* Fix theme-next#807

* Add `$b2t-opacity-hover` & Remove hover highlight
@stevenjoezhang stevenjoezhang mentioned this pull request Aug 8, 2020
Closed
47 tasks
xjay2007 added a commit to xjay2007/hexo-theme-next that referenced this pull request Sep 20, 2021
@xjay2007
Merge branch 'head_v7.1.0' into head_v7.4.0
1d06a20 
* head_v7.1.0:
  update leancloud
  mermaid config
  links add
  config update
  Fix wrong sidebar style on mobile (theme-next#808)
  fix pdf tag
  archive show month
  config
  config
  config update
  fix local search
  config update
  config update
  local search and favicon
  _config.yml

# Conflicts:
#	_config.yml
#	layout/_macro/sidebar.swig
#	layout/_third-party/comments/valine.swig
#	layout/_third-party/search/localsearch.swig
#	layout/archive.swig
#	source/css/_common/components/back-to-top-sidebar.styl
#	source/css/_common/components/back-to-top.styl
#	source/css/_common/components/sidebar/sidebar-toggle.styl
#	source/css/_mixins/base.styl
#	source/css/_variables/Mist.styl
#	source/css/_variables/base.styl
xjay2007 added a commit to xjay2007/hexo-theme-next that referenced this pull request Feb 4, 2022
@xjay2007
Merge branch 'head_v7.4.0' into head_v7.8.0
918820d 
* head_v7.4.0:
  add new friend link, change local search url pattern
  img center
  show month in archive page
  update leancloud
  mermaid config
  links add
  config update
  Fix wrong sidebar style on mobile (theme-next#808)
  fix pdf tag
  archive show month
  config
  config
  config update
  fix local search
  config update
  config update
  local search and favicon
  _config.yml

# Conflicts:
#	_config.yml
#	layout/_macro/post-collapse.swig
#	layout/_third-party/comments/valine.swig
#	source/js/local-search.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-nginx ivan-nginx ivan-nginx approved these changes

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
🐞 Bug Fix CSS Discussion
Projects
None yet
Milestone
v7.1.1
Development

Successfully merging this pull request may close these issues.

No sidebar in mobile when it open
2 participants
@stevenjoezhang @ivan-nginx