-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option onmoble
for sidebar wasn't worked
#808
Conversation
Also, I wan't to create new issue for similar component and report here: Color changed on hover b2t or sidebar toggle buttons. It's not must be (not was before). And this detected in #684. |
I think it's all fine. The old behaviour is even worse and confusing users. |
What's fine? Bug fine or what? |
It's feature. What I mean is: it's not bug. |
It's better than before. So it's fine. That's simple. |
Then create a feature with this. No need to do excess additionals. |
Better or not – no your question. For now we have:
|
So you want opacity: 0.8 on mobile? |
https://github.com/theme-next/hexo-theme-next/pull/808/files#r272229828
|
I want no excess changes for anything. See? We get 2 bugs after your refactorings. |
Ok, ok, it's my fault. What about now? |
Now right align needed. From fixbutton, how was before. |
About right margin, we only have one macro: |
I think yes. |
About margins... I see with other options and other schemes positions different in other resolutions. It's not seems like bugs, but can be improved in the future. |
We can use And, the font-size of back2top button could be larger in high-resolution screens. |
Yep. But i think not now, are u agree? At least after fonts refactoring. |
Agree. Needs to be done in the future. |
onmoble
for sidebar wasn't worked
* upstream/master: (65 commits) fix theme-next#815 (theme-next#828) Update IPC url (theme-next#827) List items appeared correctly in mobile with `mobile_layout_economy` option (theme-next#817) New translations en.yml (French) (theme-next#819) Improve French translation (theme-next#818) Fix wrong sidebar style on mobile (theme-next#808) Delete inactive reviewer New translations en.yml (Spanish) (theme-next#806) CSS bug in Codeblock if string longer than viewport (theme-next#803) Commented Project Temporairly turn off Project checking Disable Projects compairing Fix `vv` for Release Drafter Spanish translation (theme-next#801) Optimize images (theme-next#802) Release v7.1.0 Change Algolia link in config Reduce reviewers for remove scrolling in PR's (theme-next#797) Disable add Assigners in Auto Assign bot (theme-next#795) Bug Fix: PDF won't display in particular situation (theme-next#794) ...
* Fix theme-next#807 * Add `$b2t-opacity-hover` & Remove hover highlight
* head_v7.1.0: update leancloud mermaid config links add config update Fix wrong sidebar style on mobile (theme-next#808) fix pdf tag archive show month config config config update fix local search config update config update local search and favicon _config.yml # Conflicts: # _config.yml # layout/_macro/sidebar.swig # layout/_third-party/comments/valine.swig # layout/_third-party/search/localsearch.swig # layout/archive.swig # source/css/_common/components/back-to-top-sidebar.styl # source/css/_common/components/back-to-top.styl # source/css/_common/components/sidebar/sidebar-toggle.styl # source/css/_mixins/base.styl # source/css/_variables/Mist.styl # source/css/_variables/base.styl
* head_v7.4.0: add new friend link, change local search url pattern img center show month in archive page update leancloud mermaid config links add config update Fix wrong sidebar style on mobile (theme-next#808) fix pdf tag archive show month config config config update fix local search config update config update local search and favicon _config.yml # Conflicts: # _config.yml # layout/_macro/post-collapse.swig # layout/_third-party/comments/valine.swig # source/js/local-search.js
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: #807
What is the new behavior?
How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?