Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude analytics from examples page #1376

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

SutuSebastian
Copy link
Collaborator

@SutuSebastian SutuSebastian commented Apr 23, 2024

Changes

  • exclude analytics from examples page leading to page-load-count inception due to code preview examples iframe

Summary by CodeRabbit

  • New Features
    • Improved analytics script inclusion by conditionally adding it to example pages.

…t inception due to code preview examples iframe
@SutuSebastian SutuSebastian added 🐛 bug Something isn't working 📚 documentation Improvements or additions to documentation labels Apr 23, 2024
@SutuSebastian SutuSebastian self-assigned this Apr 23, 2024
Copy link

changeset-bot bot commented Apr 23, 2024

⚠️ No Changeset found

Latest commit: 34d9bff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 0:14am
flowbite-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 0:14am

Copy link
Contributor

coderabbitai bot commented Apr 23, 2024

Walkthrough

The update brings new functionality to the layout.tsx file, enhancing header handling and selectively including a script based on the page context. It refines the import setup for headers and introduces logic to conditionally determine the inclusion of the FathomScript on example pages.

Changes

File Path Changes Summary
.../layout.tsx Added header import; Conditional inclusion of FathomScript on example pages.

🐇✨
In the code's garden, changes bloom,
A rabbit hops through, room by room.
With headers new and scripts so bright,
Only on example pages, they alight.
Hop, skip, a commit, then merge,
In digital meadows, we surge. 🌼🚀


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 7a5de77 and 34d9bff.
Files selected for processing (2)
  • apps/web/app/layout.tsx (3 hunks)
  • apps/web/components/fathom-script.tsx (1 hunks)
Additional comments not posted (2)
apps/web/components/fathom-script.tsx (1)

5-12: The conditional logic to exclude analytics on the examples page is implemented correctly and efficiently.

apps/web/app/layout.tsx (1)

54-60: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [57-69]

The integration of FathomScript in the RootLayout function is done correctly, ensuring that analytics scripts do not load prematurely and affect page performance.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SutuSebastian
Copy link
Collaborator Author

As discussed with @zoltanszogyenyi .

@SutuSebastian SutuSebastian marked this pull request as ready for review April 23, 2024 12:13
@SutuSebastian SutuSebastian merged commit 2afa3c8 into main Apr 23, 2024
8 checks passed
@SutuSebastian SutuSebastian deleted the pages/examples/exclude-analytics branch April 23, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant