Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs : Toggle Switch #1321 - Issue has been fixed #1397

Merged
merged 2 commits into from
May 17, 2024

Conversation

akashMasih
Copy link
Contributor

@akashMasih akashMasih commented May 17, 2024

The toggle switch was not working properly due to missing a class inside the (packages/ui/src/components/ToggleSwitch/theme.ts). I just added two classes inside the toggle.base

Docs: Toggle Switch #1321

Summary by CodeRabbit

  • Style
    • Updated the appearance of the toggle switch with a rounded indicator and white background for a more polished look.

Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: c3fb8cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 9:17am
flowbite-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 9:17am

Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

The recent update to the toggleSwitchTheme in theme.ts enhances the visual styling of the toggle switch component by adding rounded corners and a white background to the switch's inner circle. This change improves the overall appearance and user experience of the toggle switch.

Changes

File Path Change Summary
packages/ui/src/components/ToggleSwitch/theme.ts Updated toggleSwitchTheme to include after:rounded-full after:bg-white in the base style.

🐇 In the land of code and light,
A switch now shines so bright,
Rounded corners, pure and white,
Toggle on, with all your might.
✨🖱️


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2afa3c8 and b2b484e.
Files selected for processing (1)
  • packages/ui/src/components/ToggleSwitch/theme.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/ui/src/components/ToggleSwitch/theme.ts

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between b2b484e and c3fb8cd.
Files selected for processing (1)
  • packages/ui/src/components/ToggleSwitch/theme.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/ui/src/components/ToggleSwitch/theme.ts

@rluders rluders merged commit b2640bc into themesberg:main May 17, 2024
13 checks passed
@akashMasih akashMasih deleted the fix/toggle-switch#1321 branch May 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants