Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #61: Improved git install and config docs #66

Merged
merged 2 commits into from
Jun 3, 2016

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jun 2, 2016

This fixes issue #61. Should be harmless...

@tovrstra tovrstra modified the milestone: 2.0.1 Jun 2, 2016
@tovrstra tovrstra added the Bugfix label Jun 2, 2016
@matt-chan
Copy link
Member

Typo on ln 8 in pre-commit? (doc?)

Also should it be pre-commit.sh?

@tovrstra
Copy link
Member Author

tovrstra commented Jun 3, 2016

It should be "DOS/Windows line endings" for clarity. In .git/hooks, the scripts cannot have a .sh suffix. We could add in tools and install it as follows:

cp -a tools/pre-commit.sh .git/hooks/pre-commit

However, I can see how people will get this wrong, i.e. copy it without dropping the extension, which is more work for us. I wouldn't add it.

@matt-chan
Copy link
Member

Yeah, no need. Let's just keep it as it is.

Thanks!

@matt-chan matt-chan merged commit e10bc50 into theochem:master Jun 3, 2016
@tovrstra tovrstra deleted the fix_git_docs branch June 3, 2016 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants