Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added private_only setting, as well as another method of adding userdata #15

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

kyletbase2
Copy link
Contributor

No description provided.

Copy link
Member

@aaronwalker aaronwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that it looks good

echo "userdata complete"
userdata:
- "cd /tmp \n"
- "sudo yum install -y https://s3.amazonaws.com/ec2-downloads-windows/SSMAgent/latest/linux_amd64/amazon-ssm-agent.rpm \n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this with a AMI that already had SSM agent installed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just include this in the standard userdata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronwalker
I did test it with Amazon Linux 2, it just updated the binary, BUT, as of writing this, only the regional link works:
https://s3.ap-southeast-2.amazonaws.com/amazon-ssm-ap-southeast-2/latest/linux_amd64/amazon-ssm-agent.rpm

This link doesn't (times out):
https://s3.amazonaws.com/ec2-downloads-windows/SSMAgent/latest/linux_amd64/amazon-ssm-agent.rpm
In the cloud-init-output.log:

Cannot open: https://s3.amazonaws.com/ec2-downloads-windows/SSMAgent/latest/linux_amd64/amazon-ssm-agent.rpm. Skipping.
Error: Nothing to do

But it kept going with the rest of the userdata script.

IMO it should be included, as well as maybe changing the default IAMs to include what I included with this customer:

  iam_policies:
    ecs-ssm:
      action:
        - ssmmessages:*
        - ssm:*
        - s3:GetEncryptionConfiguration

@Guslington Guslington merged commit 5f84e30 into theonestack:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants