Call destruct, there is a reference keeping it from destroying itself.

thephpleague · Mar 9, 2024 · 4d5aaca · 4d5aaca
1 parent e089524
commit 4d5aaca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/Ftp/FtpAdapterTest.php b/src/Ftp/FtpAdapterTest.php
@@ -50,7 +50,7 @@ public function disconnect_after_destruct(): void
         unset($reflection);
 
         $this->assertTrue(false !== ftp_pwd($connection));
-        unset($adapter);
+        $adapter->__destruct();
         static::clearFilesystemAdapterCache();
         $this->assertFalse((new NoopCommandConnectivityChecker())->isConnected($connection));
     }

diff --git a/src/Ftp/FtpAdapterTestCase.php b/src/Ftp/FtpAdapterTestCase.php
@@ -32,15 +32,9 @@ protected function setUp(): void
         $this->retryOnException(UnableToConnectToFtpHost::class);
     }
 
-    /**
-     * @var ConnectivityCheckerThatCanFail
-     */
-    protected static $connectivityChecker;
+    protected static ConnectivityCheckerThatCanFail $connectivityChecker;
 
-    /**
-     * @var StubConnectionProvider
-     */
-    protected static $connectionProvider;
+    protected static ?StubConnectionProvider $connectionProvider;
 
     /**
      * @after