Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Only allow scalar configuration values #152

Open
aimeos opened this issue May 1, 2017 · 3 comments
Open

[3.0] Only allow scalar configuration values #152

aimeos opened this issue May 1, 2017 · 3 comments

Comments

@aimeos
Copy link
Contributor

aimeos commented May 1, 2017

I would propose to reapply https://github.com/thephpleague/omnipay-common/pull/81/files

The commit has been reverted because for 2.x this may have been a breaking change as e.g. the PayPal drivers sets the credit card object using setParameter() too. For Omnipay 3.x we can be more restrictive now to increase driver quality

@barryvdh
Copy link
Member

barryvdh commented May 1, 2017

I want the 3.x release be as non-breaking as possible.

@colinodell
Copy link
Member

Could we use Symfony's OptionResolver for this? It supports type validation.

@aimeos
Copy link
Contributor Author

aimeos commented May 1, 2017

It doesn't involve a break in the API but only a change to decrease the probability of implementing something unusable in the drivers.

@colinodell I wouldn't make it to complicated. Scalar or not is enough to avoid objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants