Use notifyUrl not returnUrl for callback #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omnipay supports a notifyUrl for callbacks and a returnUrl for the browser. This patch causes the notifyUrl to be used for callbacks by securePay
|
Oops, I just saw this when I went to merge something else. Can you please make this backwards compatible for existing users? Something similar got done for Authorize.Net -- use the notifyUrl if it's set but use the returnUrl if the notifyUrl is not set. |
|
I can't even remember doing this one - I think it was never put into use. But, I copied the code from a.net and actually learnt something - I didn't know you could have a blank in the ternery operator like that |
|
Once again if someone can test that this works in production I wiil tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omnipay supports a notifyUrl for callbacks and a returnUrl for the browser. This patch causes the notifyUrl to be used for callbacks by securePay