Reverted to last known working version of Storybook #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid this breaking without noticing in the future, I suggest we get storybook at least building during CI. That way we can at least see if dependency upgrades break it. Longterm we should get back on #338. |
maestromac
approved these changes
Dec 27, 2018
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
This was referenced Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Storybook was no longer building due to dependency upgrades which were no longer comaptible with Preact.
@maestromac, alright, so reverting to 3.4.11 for all the storybook dependencies gets us back up and running. I did however manage to get it running with the latest storybook. The only caveat is that I need to install React as a dev dependency. Not ideal, but it works.
I think for the time being, we should probably just go back to 3.4.11 unless the dev.to team is OK with React being in there as a dev dependency.
Related Tickets & Documents
#1407
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?