Mute notifications for your own article #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhao-Andy
commented
Jan 18, 2019
| def send_new_comment_notifications(notifiable) | ||
| user_ids = notifiable.ancestors.map(&:user_id).to_set | ||
| user_ids.add(notifiable.commentable.user.id) if user_ids.empty? | ||
| user_ids = notifiable.ancestors.select(:receive_notifications, :user_id).select(&:receive_notifications).pluck(:user_id).to_set |
There was a problem hiding this comment.
This might be an overkill "faster" query.
Zhao-Andy
changed the title
pr-triage
bot
removed
the
PR: unreviewed
Zhao-Andy
changed the title
benhalpern
requested changes
Jan 21, 2019
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
Zhao-Andy
commented
Jan 21, 2019
|
Have to fix some tests first for the email notification part. |
benhalpern
approved these changes
Jan 22, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This allows authors to mute notifications from their articles.
Resolves #234, partially.
WIP:Wasn't sure how to write a test for muting email notifications.
Screenshots
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?