Skip to content

Enhance Internal Index Pages #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 6, 2019
Merged

Enhance Internal Index Pages #1747

merged 6 commits into from
Feb 6, 2019

Conversation

jessleenyc
Copy link
Contributor

@jessleenyc jessleenyc commented Feb 5, 2019 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

On Tags:

  • Moved editing tags to internal/tags/:Id
  • Added editing for aliases and tag moderators to internal/tags/:id
  • When adding a tag moderator to a tag, the user will now automatically receive an email.
  • Added search/pagination to internal/tags index and improved styling/info displayed

On Users:

  • Added more info on user index

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@jessleenyc jessleenyc changed the title [WIP] Enhance Internal Index Pages Enhance Internal Index Pages Feb 6, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Feb 6, 2019
benhalpern
benhalpern approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 6, 2019
@benhalpern benhalpern merged commit 54426ea into forem:master Feb 6, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 6, 2019
@weekly-digest weekly-digest bot mentioned this pull request Feb 11, 2019
Closed
@jessleenyc jessleenyc deleted the jess/internal-index-enhancement branch July 29, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessleenyc @benhalpern