Skip to content

Added <kbd> tag support to markdown editors in article posts and comm… #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 17, 2019
Merged

Added <kbd> tag support to markdown editors in article posts and comm… #1761

merged 8 commits into from
Feb 17, 2019

Conversation

deadlybyte
Copy link
Contributor

…ents.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Added tag support to markdown editors in article posts and comments.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

kbd-tag-support-for-markdown-editors

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

<kbd> tag goodness

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Feb 7, 2019
benhalpern
benhalpern approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Due to the additional linting here, I'd love another set of eyes to double check for me that everything looks good.

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 8, 2019
@rhymes
Copy link
Contributor

rhymes commented Feb 8, 2019

@benhalpern if you disable whitespace changes in the diff the changeset is more "digestible"

screenshot_2019-02-08 added kbd tag support to markdown editors in article posts and comm by deadlybyte pull request 17

this should help...

Zhao-Andy
Zhao-Andy suggested changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one change needed!

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Feb 8, 2019
@deadlybyte
Copy link
Contributor Author

deadlybyte commented Feb 8, 2019 •
edited
Loading

Added additional refactoring and used SASS placeholder for the kbd class as no need to output a class .kbd as it wasn't being used - only referenced via extend.

Zhao-Andy
Zhao-Andy approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 8, 2019
jessleenyc
jessleenyc reviewed Feb 8, 2019
View reviewed changes
jessleenyc
jessleenyc reviewed Feb 8, 2019
View reviewed changes
jessleenyc
jessleenyc requested changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@jessleenyc jessleenyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments above

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 8, 2019
@pr-triage pr-triage bot removed the PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes label Feb 8, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Feb 8, 2019
@deadlybyte deadlybyte force-pushed the feature/kbd-tag-support-in-markdown branch from 5b32c30 to 0d34c2d Compare February 8, 2019 22:00
@weekly-digest weekly-digest bot mentioned this pull request Feb 11, 2019
Closed
Zhao-Andy
Zhao-Andy approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good once this passes CI!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 15, 2019
@benhalpern benhalpern merged commit c1eecd1 into forem:master Feb 17, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 17, 2019
@weekly-digest weekly-digest bot mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessleenyc jessleenyc jessleenyc requested changes

@benhalpern benhalpern benhalpern approved these changes

@maestromac maestromac Awaiting requested review from maestromac

@aspittel aspittel Awaiting requested review from aspittel

+1 more reviewer

@Zhao-Andy Zhao-Andy Zhao-Andy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deadlybyte @CLAassistant @rhymes @benhalpern @jessleenyc @Zhao-Andy