Organization Notifications #1762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhalpern
approved these changes
Feb 25, 2019
pr-triage
bot
added
PR: reviewed-approved
benhalpern
approved these changes
Feb 25, 2019
pr-triage
bot
added
PR: unreviewed
pr-triage
bot
added
PR: merged
Glennmen
added a commit
to Glennmen/dev.to
that referenced
this pull request
Feb 26, 2019
* master: (31 commits) Fix typo in badge show page and fix unrelated badge missing word (forem#1899) Add additional streak badge rewarding (forem#1896) Organization Notifications (forem#1762) Fix linting issues in app/views/notifications (forem#1894) [ci skip] Fix linting issues in app/views/organizations (forem#1895) Fix linting issues in app/views/admin (forem#1871) [ci skip] Fix linting issues in app/views/internal (forem#1882) [ci skip] Fix linting issues for app/views/internal/articles (forem#1873) Fix linting issues in app/views/mailers (forem#1889) [ci skip] Fix linting issues in app/views/layouts (forem#1884) [ci skip] Fix linting issues in app/views/fields (forem#1862) [ci skip] Disable useless assignment linting in views (forem#1886) [ci skip] Fix linting issues in app/views/giveaways (forem#1863) Fix linting issues in app/views/events (forem#1860) [ci skip] Fix linting issues in app/views/devise (forem#1858) [ci skip] Fix linting issues in app/views/comments (forem#1853) [ci skip] Fix linting issues in app/views/email_subscriptions (forem#1859) [ci skip] Fix linting issues in app/views/feedback_messages (forem#1861) Fix linting issues in app/views/chat_channels (forem#1852) [ci skip] Fix linting issues in app/views/blocks (forem#1851) [ci skip] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This adds notifications for organizations! 🎉
Implementation details:
memberof the organization can view the org's notifications.read./notifications/org/:org_idand/notifications/comments/:org_id. This keeps it flexible for people who belong to multiple orgs.postsbecause orgs can't follow people (and therefore cannot receive notifications for new posts).One feature I forgot -- I remembered just now while writing is -- is the ability for orgs to send a new post notification to their followers. I can add this in if we want. Don't think it would take too much time.Just added this 👍Related Tickets & Documents
Resolves #1222
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Mobile View
Desktop View
[optional] What gif best describes this PR or how it makes you feel?