Skip to content

Fix delayed job errors related to reactions #1621 #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 28, 2019
Merged

Fix delayed job errors related to reactions #1621 #1883

merged 19 commits into from
Feb 28, 2019

Conversation

lightalloy
Copy link
Contributor

Fix Delayed::DeserializationError: ActiveRecord::RecordNotFound related to destroyed Reactions .

* moved async methods to separate jobs

* added checks to ensure that a record still exists

* added specs for the `Reaction` model, (for the `after_save` callbacks behavior)

I kept the old methods #touch_user_without_delay, #update_reactable_without_delay, #occasionally_sync_reaction_counts, #bust_reactable_cache_without_delay which were used before, in case there will be jobs, which were created but were not executed by the deploy time.

@lightalloy
Add delayed_job_web to dev environment for debugging
d755cf7
@lightalloy
Add specs for the current Follow callbacks implementation
9900a40
@lightalloy
Move follower touching to ActiveJob
5f56140
@lightalloy
Spec for the touch followers job
bbce739
@lightalloy
Move Follow#create_chat_channel to ActiveJob and make the job safe
9efe5b8
@lightalloy
Add ActiveJob to send email notifications about follows
5fcfeba
@lightalloy
Enqueue SendEmailNotificationJob after the follow is created
fb75dea
@lightalloy
Specs to wnsure jobs are enqueued on Follow creation
61b0b9c
@lightalloy
Make CreateChatChannelJob queue name more specific
bf9a85d
@lightalloy
Reaction specs for Reaction after_save callbacks logic
c18c96f
@lightalloy
Touch user job
3214456
@lightalloy
Merge branch 'master' into bug/fix-delayed-job-errors-reactions
b31afda
@lightalloy
Call Users::TouchJob on reaction create
bbc64a6
@lightalloy
Move updating reactable to a separate job
72680ec
@lightalloy
Move busting reactable cache to a separate job
1a69063
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Feb 25, 2019
@lightalloy lightalloy force-pushed the bug/fix-delayed-job-errors-reactions branch from b73963d to 2d59a8b Compare February 25, 2019 11:52
@lightalloy lightalloy marked this pull request as ready for review February 26, 2019 10:21
@lightalloy lightalloy changed the title Fix delayed job errors related to reactions [WIP] Fix delayed job errors related to reactions Feb 26, 2019
@pr-triage pr-triage bot removed the PR: unreviewed bot applied label for PR's with no review label Feb 26, 2019
@lightalloy lightalloy changed the title [WIP] Fix delayed job errors related to reactions Fix delayed job errors related to reactions Feb 26, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Feb 26, 2019
@lightalloy lightalloy changed the title Fix delayed job errors related to reactions Fix delayed job errors related to reactions #1621 Feb 26, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 28, 2019
@benhalpern benhalpern merged commit 8751143 into forem:master Feb 28, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 28, 2019
@lightalloy lightalloy deleted the bug/fix-delayed-job-errors-reactions branch February 28, 2019 07:23
Glennmen added a commit to Glennmen/dev.to that referenced this pull request Feb 28, 2019
@Glennmen
Merge branch 'master' into lint/fix-linting-api-views
d048120 
* master:
  Fix delayed job errors related to reactions forem#1621 (forem#1883)
  Change OP to AUTHOR (forem#1919)
  add username to author info (forem#1912)
  Add test for validation badge image (forem#1909) [ci skip]
  Adjust article ranking algorithm to use crossposted_at where available (forem#1917)
  Remove unused Follow methods (forem#1915) [ci skip]
  Fix linting issues in app/views/dashboards (forem#1854) [ci skip]
  Add OP badge on comments (forem#461)
  Fix settings/mentorship SyntaxError (forem#1913)
  Fix linting issues in app/views/users (forem#1908)
  Fix linting issues in app/views/stripe_subscriptions (forem#1905) [ci skip]
  Fix linting issues in app/views/podcast_episodes (forem#1898) [ci skip]
  Fix linting issues in app/views/moderations (forem#1900) [ci skip]
  Fix linting issues in app/views/reading_list_items (forem#1902) [ci skip]
  Fix linting issues for app/views/tags (forem#1906) [ci skip]
  Fix linting issues in app/views/pages (forem#1897)
  Fix linting issues in app/views/social_previews (forem#1903) [ci skip]
  Fix linting issues for app/views/stories (forem#1904) [ci skip]
  Fix linting issues for app/views/html_variants (forem#1872) [ci skip]
  Add missing argument for reaction notification (forem#1901)
@weekly-digest weekly-digest bot mentioned this pull request Mar 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lightalloy @benhalpern