Feature/blogcast liquid tag #1891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Oh cool, we'd definitely love to offer this. @Zhao-Andy wanna review this? |
Zhao-Andy
suggested changes
Feb 27, 2019
pr-triage
bot
added
PR: reviewed-changes-requested
Co-Authored-By: m1guelpf <github@miguelpiedrafita.com>
pr-triage
bot
added
PR: unreviewed
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
|
Hey @m1guelpf, I meant to say this when it was merged, but feel free to write up a changelog post for this if you'd like. :) Here's an example: https://dev.to/link2twenty/changelog-jsfiddle-liquid-tags-now-live-1d1b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I use Blogcast to generate audio versions of my articles, and as Dev.to doesn't allow raw embeds, I figured out I'd try to add it.
(DISCLAIMER: Blogcast is not a free product ($0.50/article), and I'm the creator. I'd totally understand if any of those things made you reject the contribution. Just wanted to contribute something, no hard feelings 😄)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
docs.dev.to
readme
no documentation needed
liquid tags documentation page
[optional] What gif best describes this PR or how it makes you feel?